shreemaan-abhishek commented on code in PR #13905:
URL: https://github.com/apache/apisix/pull/13905#discussion_r3921032776
##########
apisix/plugins/wolf-rbac.lua:
##########
@@ -276,6 +313,14 @@ function _M.rewrite(conf, ctx)
return 401, fail_response("Invalid appid in rbac token")
end
core.log.info("consumer appid: ", appid)
+ local prefix = conf.header_prefix
Review Comment:
Good catch — agreed. Removing the schema default does not distinguish an
older persisted default from an intentional Route value.
I updated the PR to preserve the historical contract: Consumer
`header_prefix` remains the fallback, while a new Route/Service-only
`output_header_prefix` is the explicit opt-in for Route precedence. Stored
Route `header_prefix` values remain accepted but do not override the Consumer
prefix.
I also added an upgrade regression with a stored Route `header_prefix: "X-"`
and a Consumer using `X-Wolf-`; it verifies that the authenticated identity
still replaces the Consumer-prefixed headers. The focused multi-auth suite
passes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
