CastilloLuis commented on PR #13920: URL: https://github.com/apache/apisix/pull/13920#issuecomment-5550375214
A note on verification, since I said above that I could not run Test::Nginx locally. To avoid leaving the transport change resting only on `luacheck`, I drove the real `_M.request` in `ai-transport/http.lua` under LuaJIT with the HTTP client, `core` and `socket.url` stubbed, and asserted the redirect behaviour directly. All nine cases pass: | case | asserted | |---|---| | same-origin `307` | followed; method, body, `Authorization` and target query all preserved on the replay | | cross-origin host | refused, request errors | | port differs | refused | | scheme differs | refused | | relative `Location` | treated as same-origin, followed | | redirect carries no query | original query is kept, so `auth.query` providers stay authenticated | | no `Location` header | errors rather than passing through silently | | provider without `follow_redirects` | unchanged: the `307` is returned as-is, one request made | | non-redirect status | untouched, one request made | That harness is a local scratch tool, not something I have added to the PR — the committed coverage is `t/plugin/ai-proxy-thegrid.t`, which still needs a run of the real suite. It looks like the workflows are waiting on maintainer approval, so please do kick them off; if anything in that file is wrong I would rather find out now than after review time is spent on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
