shreemaan-abhishek commented on code in PR #2875:
URL:
https://github.com/apache/apisix-ingress-controller/pull/2875#discussion_r4035142971
##########
internal/adc/translator/httproute.go:
##########
@@ -711,7 +723,7 @@ func (t *Translator) TranslateHTTPRoute(tctx
*provider.TranslateContext, httpRou
enableWebsocket, _ := t.translateBackendsToUpstreams(tctx,
rule, httpRoute, service)
if err := t.fillPluginsFromHTTPRouteFilters(service.Plugins,
httpRoute.GetNamespace(), rule.Filters, rule.Matches, tctx); err != nil {
- return nil, err
+ setExtensionRefErrorResponse(service)
Review Comment:
Fixed in 73774fb6. HTTPRoute and GRPCRoute translation now log the original
filter error with the route namespace, name, and rule index before installing
the per-rule error response. Added regression coverage, including an assertion
that configuration content is not logged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
