bhuvan-somisetty opened a new pull request, #13974:
URL: https://github.com/apache/apisix/pull/13974

   ### Description
   
   `send_syslog_data` in the syslog plugin concatenated the underlying error 
directly onto its message, so the batch processor logged run-together text such 
as `failed when initiating the sys logger processorconnection refused` or 
`failed to log messagebuffer overflow`.
   
   This adds a `": "` separator to both messages, consistent with the rest of 
the code base (e.g. `'failed to loadstring: ' .. err`). Only the error strings 
change; no behavior, return values or config are affected.
   
   A test mocks the socket logger so that `log()` fails and asserts the error 
line reads `failed to log message: mocked send failure`. The other message 
(logger init failure) shares the same fix, but its test depends on the 
nil-logger crash fix in #13970, so it is not covered here.
   
   #### Which issue(s) this PR fixes:
   Fixes #13973
   
   ### Checklist
   
   - [x] I have explained the need for this PR and the problem it solves
   - [x] I have explained the changes or the new features added to this PR
   - [x] I have added tests corresponding to this change
   - [x] I have updated the documentation to reflect this change
   - [x] I have verified that this change is backward compatible (If not, 
please discuss on the [APISIX mailing 
list](https://github.com/apache/apisix/tree/master#community) first)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to