bzp2010 commented on PR #13989: URL: https://github.com/apache/apisix/pull/13989#issuecomment-5863539157
@shreemaan-abhishek The issues with the lago tests will not be fixed in this PR. This PR does not help resolve the tests that currently fail to run, because the underlying conditions have not changed: dependencies are still downloaded during test execution and may fail. The timeout duration for Node.js child processes is unpredictable, but `test::nginx` enforces an empirical value and does not support proper retries—and that is the crux of the problem. Simply migrating to `vitest` does not guarantee that `lago` tests will always pass. This PR is merely the first part of a broader refactoring, serving as the starting point for splitting the TypeScript-based tests from test::nginx. Currently, the tests rely on `test::nginx` to prepare the `nginx.conf` configuration and start OpenResty; the TypeScript tests are simply embedded as a single test case within `test::nginx` and run as a subprocess. TypeScript lacks both a proper runtime and the ability to directly manage OpenResty’s configuration and lifecycle, which requires systematic improvements. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
