shreemaan-abhishek commented on code in PR #13038:
URL: https://github.com/apache/apisix/pull/13038#discussion_r4130375621


##########
apisix/plugins/openid-connect-idp-selector.lua:
##########


Review Comment:
   I think we don't need this (and the plugin declaration) anymore, do we?
   
     Removal should include:
   
     - apisix/plugins/openid-connect-idp-selector.lua
     - Its plugin registration in apisix/cli/config.lua
     - Its entry in conf/config.yaml.example
     - English and Chinese selector documentation
     - Documentation navigation entries
     - t/plugin/openid-connect-idp-selector.t
     - Admin plugin-list expectations
     - References from openid-connect.md that present it as the built-in 
selector



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to