nic-6443 opened a new pull request, #14017: URL: https://github.com/apache/apisix/pull/14017
The `$rate_limiting_info` section added in #13996 says the delayed-sync snapshot is only refreshed after its window has ended. That's wrong. `sync_key` replaces it through `sync_to_shm` on every periodic synchronization, which runs within `sync_interval` after a request (since #14015 also when there is no local delta), and the snapshot is refreshed again when it expires at the end of its window. This corrects the sentence in en and zh. What it was explaining still holds: a request that arrives after a window boundary but before the next synchronization is still checked against the previous snapshot, so its `evaluated_at_ms` can briefly be later than `current_window.end_ms`. - [x] I have explained the need for this PR and the problem it solves - [x] I have explained the changes or the new features added to this PR - [ ] I have added tests corresponding to this change - [x] I have updated the documentation to reflect this change - [x] I have verified that this change is backward compatible -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
