shreemaan-abhishek commented on PR #14016: URL: https://github.com/apache/apisix/pull/14016#issuecomment-6073166057
Updated in fc7338c80, carrying two more fixes from review on the paired EE PR: - `core.request.header` collapses a repeated header to its first value, so a request with two `Content-Encoding: gzip` lines had its twice compressed body restored while advertising a single `gzip`. The header is now rebuilt from the parsed coding list, which RFC 9110 section 5.3 makes equivalent to the repeated lines, and the separately stored header value is gone as redundant. - `before_proxy` read the current body with an `or ""` fallback, so a body file that cannot be read became an empty body that was compressed and forwarded. A read failure is now an error, and the fallback covers only the genuine no-body case. Two new regressions for these, taking `t/plugin/request-decompress.t` to 44 blocks / 163 subtests, all passing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
