shreemaan-abhishek commented on code in PR #2900:
URL:
https://github.com/apache/apisix-ingress-controller/pull/2900#discussion_r4228750056
##########
internal/controller/indexer/indexer.go:
##########
@@ -263,6 +283,48 @@
return secretKeys
}
+// GenKeyAuthKeyIndex hashes a key-auth key so the index never holds plaintext.
+func GenKeyAuthKeyIndex(key string) string {
+ sum := sha256.Sum256([]byte(key))
Review Comment:
False positive. The hash is only an in-memory lookup key for a field index.
It is never stored, logged, or sent anywhere, and the plaintext key already
sits in the same process cache, so there is nothing to crack offline. SHA-256
here only keeps plaintext out of the index.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
