AlinsRan commented on PR #2871:
URL:
https://github.com/apache/apisix-ingress-controller/pull/2871#issuecomment-6091683422
@Lcos-000 Two things need to be addressed:
**1. Please resolve the conflicts with master.**
**2. The `Store.Delete` change reintroduces the bug fixed in #2885**
```go
if len(resourceTypes) == 0 {
delete(s.cacheMap, name)
...
return nil
}
```
Deleting an ApisixGlobalRule calls `Store.Delete` with empty
`resourceTypes`. With this branch, deleting a single ApisixGlobalRule wipes
every resource under the whole GatewayProxy. #2885 removed this special case to
fix exactly that; wiping the whole config is now done by `DeleteAll`.
Please drop this branch and use `DeleteAll` when a GatewayProxy is deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
