AGheller opened a new pull request, #1020:
URL: https://github.com/apache/apisix-helm-chart/pull/1020
Fixes #1019
### What
#950 restricted `externalTrafficPolicy` in the gateway Service to
`LoadBalancer` and `NodePort`, to fix #755 (the API server rejects the field on
a plain ClusterIP Service). Kubernetes also accepts it on a `ClusterIP` Service
with `externalIPs`, where kube-proxy honors it, and setting it to `Local` is
the way to preserve the client source IP in that setup. Since 2.18.0 the field
is silently dropped there and the Service falls back to `Cluster`.
This PR also renders the field when `service.externalIPs` is set.
### Rendering (`helm template --show-only templates/service-gateway.yaml`)
| Values | Before | After |
|---|---|---|
| `type=ClusterIP`, `externalIPs={1.2.3.4}`, `externalTrafficPolicy=Local` |
field omitted | `externalTrafficPolicy: Local` |
| `type=ClusterIP`, no `externalIPs` | field omitted | field omitted (#755
fix kept) |
| `type=NodePort`, `externalTrafficPolicy=Local` | `Local` | `Local` |
| defaults | omitted | omitted |
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
