AlinsRan opened a new pull request, #1021: URL: https://github.com/apache/apisix-helm-chart/pull/1021
Fixes #995. ### Problem In `charts/apisix/templates/configmap.yaml`, `deployment.admin.enable_admin_ui` is only rendered when `etcd.enabled` is true. With an external etcd (`etcd.enabled: false`), the key is dropped, APISIX falls back to its default `enable_admin_ui: true`, and the embedded dashboard is served on the Admin API port even though the user set `apisix.admin.enable_admin_ui: false`. The setting controls the Admin API server, not etcd connectivity, so it should not depend on how etcd is deployed. ### Change Remove the `etcd.enabled` guard so `enable_admin_ui` is always rendered in the `admin` block. The block itself is still skipped for the `data_plane` role, as before. ### Verification `helm template` on `charts/apisix`: | Values | Before | After | |---|---|---| | `etcd.enabled=false`, external etcd, `apisix.admin.enable_admin_ui=false` | key missing (APISIX default `true`) | `enable_admin_ui: false` | | defaults | `enable_admin_ui: true` | unchanged | | `mode=decoupled`, `role=control_plane` | `enable_admin_ui: true` | unchanged | | `mode=standalone`, `role=data_plane` | no `admin` block | unchanged | `helm lint charts/apisix` passes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
