AlinsRan opened a new pull request, #1022: URL: https://github.com/apache/apisix-helm-chart/pull/1022
Fixes #986. ### Problem The controller's health probe address is configurable through `config.probeAddr` and rendered into the controller config as `probe_addr`, but the liveness and readiness probes in `templates/deployment.yaml` hardcode port `8081`. Changing `config.probeAddr` moves the probe server while the kubelet keeps probing `8081`, so the pod never becomes ready and is eventually restarted. ### Change - Add a helper `apisix-ingress-controller.probePort` that takes the port after the last `:` in `config.probeAddr` (defaulting to `:8081`, the same default the configmap uses). - Use it for the `httpGet.port` of both the liveness and readiness probes of the `manager` container. The rendered default is unchanged (`port: 8081`). ### Verification `helm template` on `charts/apisix-ingress-controller`: | `config.probeAddr` | `probe_addr` in config | probe ports | |---|---|---| | default (`:8081`) | `:8081` | `8081` | | `:9091` | `:9091` | `9091` | | `0.0.0.0:9092` | `0.0.0.0:9092` | `9092` | | `[::]:9093` | `[::]:9093` | `9093` | | empty | `:8081` | `8081` | `helm lint charts/apisix-ingress-controller` passes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
