ruanweihong-aaa commented on PR #14057: URL: https://github.com/apache/apisix/pull/14057#issuecomment-6330036637
The HTTPS mock here appears to be lost before verification: https://github.com/apache/apisix/blob/5460871d51ff68d85d53f18a9eefd8c515e12751/t/node/client-mtls.t#L883-L885 `http_access_phase()` creates a new `api_ctx` and initializes its variables: https://github.com/apache/apisix/blob/5460871d51ff68d85d53f18a9eefd8c515e12751/apisix/init.lua#L850-L855 Our Nginx probe confirmed that the verifier receives `http`, so this test does not reach the new nil guard. Could you mock the scheme on the context created inside `http_access_phase()`, or test the verifier directly? Ideally, the test should fail on base with the intended nil error and pass with this fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
