AlinsRan commented on PR #957:
URL:
https://github.com/apache/apisix-helm-chart/pull/957#issuecomment-6335524086
Thanks @dpagidas, and sorry for the wait. The template change looks good. I
pushed two commits to this branch so CI can pass:
1. **Merged `master`** to bring the branch up to date.
2. **Bumped the chart to `1.4.1`.** `ct lint` requires a version bump for
any chart change.
3. **Regenerated the README with `helm-docs`.** CI checks that the README
matches the values file, and the new `deployment.priorityClassName` row was
missing.
4. **Aligned the value description** with the `apisix` and
`apisix-dashboard` charts:
```yaml
# -- Set the
[priorityClassName](https://kubernetes.io/docs/concepts/scheduling-eviction/pod-priority-preemption/#pod-priority)
for the ingress controller pods
priorityClassName: ""
```
Verified locally: `helm lint` passes. With
`deployment.priorityClassName=system-cluster-critical` the field renders on the
pod spec, and the default output contains no `priorityClassName` field.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
