Moep90 commented on issue #978:
URL: 
https://github.com/apache/apisix-helm-chart/issues/978#issuecomment-6342664611

   Until there's a value for it, a JSON patch on the rendered chart adds the 
label to the pod template only. Tested with chart 1.4.0:
   
   ```yaml
   resources:
     - helm.yaml
   patches:
     - target:
         group: apps
         kind: Deployment
         name: apisix-ingress-controller
       patch: |-
         - op: add
           path: /spec/template/metadata/labels/team
           value: platform
   ```
   
   A key with a slash goes in with `~1`, e.g. `labels/example.com~1team`. I 
wouldn't use `labelsOverride` for this. It replaces the selector labels, so the 
new label also lands in the Deployment's `spec.selector`, and on an existing 
install the API server rejects that as immutable. I checked both on kind; the 
controller pod came up Ready with the label.
   
   Details, and the same patch with Kapitan: 
https://kadet-hub.org/blog/kustomize-json-patch-helm-chart/#apisix-ingress-controller-pod-labels
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to