venkatapgummadi commented on PR #13302: URL: https://github.com/apache/apisix/pull/13302#issuecomment-6448436102
Thanks @hanzhenfang I’ve addressed this in commit 5ec20cf0. The initial retry interval now requires at least 1 second, and the documentation reflects that. The default remains 40 seconds. I added tests for failures, exceptions, the backoff cap, and reset after success, along with zero-interval validation in both configuration modes. The watch-tuning and Kubernetes schema suites pass in Docker with 43 assertions. I also confirmed that the zero-interval regression test fails against the original schema and passes with the fix. Please take look when you have a chance. Thanks for the review! Venkata On Sun, Oct 25, 2026 at 8:50 AM 韩振方 ***@***.***> wrote: > *hanzhenfang* left a comment (apache/apisix#13302) > <https://github.com/apache/apisix/pull/13302#issuecomment-6397853743> > > Thanks for the PR, @venkatapgummadi <https://github.com/venkatapgummadi>! > > The schema allows watch_retry_interval_seconds = 0, but a failed > list_watch then reaches the "Success: reset" branch and schedules another > zero-delay timer. This never backs off, even when watch_retry_max_seconds > is positive. > > Could we either require a positive initial interval, or explicitly define > and test zero as disabling backoff? Could we also add tests around > start_fetch that assert the scheduled delays for failures/exceptions, the > cap, and reset after success? The new tests currently cover validation and > option propagation, but do not exercise this retry loop. > > This observation is based on source review of a4a17ae3; I have not run > the retry scenario locally. > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/apisix/pull/13302?email_source=notifications&email_token=BZYYL7KB7CMXQLO2LDJWJ4D5VXZJNA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMMZZG44DKMZXGQZ2M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-6397853743>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/BZYYL7JHKJVHI4QQZBR56WD5VXZJNAVCNFSNUABFKJSXA33TNF2G64TZHMYTQMBUHAYTSOBWHNEXG43VMU5TIMZTGI4DIOBWGQ22C5QC> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
