membphis commented on PR #14088: URL: https://github.com/apache/apisix/pull/14088#issuecomment-6458859366
Known, non-blocking follow-up for this PR: when no explicit `introspection_endpoint` is configured and discovery is unavailable, one introspection request that becomes the coordination owner calls the same failing discovery `httpc:request_uri` **4 times in lua-resty-openidc 1.9.3, versus 2 times in 1.9.0**. Reproduced with unmodified, pinned upstream modules and a deterministic failing HTTP transport: ```text 1.9.0: discovery_request_uri_calls=2; failure=nil 1.9.3: discovery_request_uri_calls=4; failure=endpoint_unavailable ``` The extra attempts come from cache-key construction and the post-lock cache recheck repeatedly resolving discovery. The cache rechecks/coordination should remain; endpoint resolution can be reused within the request. An isolated guard prototype reduced the failure count to 1 while preserving the same 503 classification and passing 13 fixture-backed control cases. This is not a full NGINX concurrency test. Please address the endpoint-resolution reuse in upstream `lua-resty-openidc` first, then follow up with the APISIX dependency update and regression coverage. This affects the discovery failure path, not normal successful requests, and does not block merging this upgrade. Tracking: https://github.com/zmartzone/lua-resty-openidc/issues/579 and https://github.com/apache/apisix/issues/14114. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
