kayx23 commented on code in PR #14067: URL: https://github.com/apache/apisix/pull/14067#discussion_r4510316144
########## docs/en/latest/plugins/grpc-transcode.md: ########## @@ -83,6 +83,8 @@ docker run -d \ api7/grpc-server-example:1.0.2 ``` +These examples use `127.0.0.1:50051` as the upstream address and assume APISIX runs on the Docker host. If APISIX runs in a container, connect both containers to the same [user-defined Docker network](https://docs.docker.com/engine/network/drivers/bridge/) and replace `127.0.0.1:50051` in the Route configurations with `grpc-example-server:50051`. Inside the APISIX container, `127.0.0.1` refers to APISIX itself; Docker resolves the upstream container name on the shared network. Review Comment: Please drop this `grpc-transcode` hunk from this PR, or update it after #14048 lands. #14048 already fixes the same broken container-network example comprehensively by placing the server on `apisix-quickstart-net`, pinning the tested image, and changing every Route to use the container DNS name. Keeping this alternate host-vs-container note here creates two competing fixes and will conflict with the canonical example. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
