nic-6443 commented on code in PR #1034:
URL: 
https://github.com/apache/apisix-helm-chart/pull/1034#discussion_r4532857019


##########
charts/apisix/README.md:
##########
@@ -72,6 +72,51 @@ OpenShift that assign a UID, omit the explicit `runAsUser` 
value.
 These options do not configure `extraInitContainers` and have no effect when
 `etcd.enabled` is false.
 
+## Connect to external etcd with server-only TLS
+
+For external etcd, the URL scheme in `externalEtcd.host` selects HTTP or HTTPS.
+`etcd.auth.tls.enabled` controls client certificates; leave it `false` when 
etcd
+does not require a client certificate. The `verify` and `sni` settings apply
+independently of that flag.
+
+For example, to connect to an IP endpoint using a CA stored in a Secret:
+
+```yaml
+apisix:
+  ssl:
+    enabled: true
+    existingCASecret: etcd-ca
+    certCAFilename: ca.crt
+etcd:
+  enabled: false
+  auth:
+    tls:
+      enabled: false

Review Comment:
   This configuration is unreasonable. When `tls.enabled` is set to false, the 
configured sni and verify become meaningless:
   ```
           {{- if .Values.etcd.auth.tls.enabled }}
           tls:
             {{- .with .Values.etcd.auth.tls.certFilename }}
             cert: "/etcd-ssl/{{ .Values.etcd.auth.tls.certFilename }}"
             key: "/etcd-ssl/{{ .Values.etcd.auth.tls.certKeyFilename }}"
             {{- end }}
             verify: {{ .Values.etcd.auth.tls.verify }}
             {{- with .Values.etcd.auth.tls.sni }}
             sni: {{ . | quote }}
             {{- end }}
           {{- end }}
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to