moonming commented on PR #14004:
URL: https://github.com/apache/apisix/pull/14004#issuecomment-6792929301
The fix is right, but the failure mode in the description isn't what
happens: lua-nginx-module's `sock:send()` accepts nil and sends the literal
bytes `nil` (see the `LUA_TNIL` branch in `ngx_http_lua_socket_tcp_send`). On
master the log server receives `nil` and the batch is counted as delivered.
Could you update the description?
Because of that, TEST 18 also passes with the fix reverted: the old code
already logs `error occurred while encoding the data: ...`, and `bad argument
#1 to 'send'` can never appear. Please assert the line that only the fixed code
emits:
--- error_log
Batch Processor[log buffer] failed to process entries: error occurred
while encoding the data: mocked encoding error
and drop the `no_error_log` check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
