shreemaan-abhishek opened a new pull request, #14197:
URL: https://github.com/apache/apisix/pull/14197

   ### Description
   
   `install_brotli()` builds brotli from source against a pinned upstream tag, 
in CI and in the dev image, and the `brotli` plugin docs tell users to do the 
same. A source build never receives the distribution's security updates, and it 
leaves no package-manager entry, so it is invisible to image and host scanners.
   
   This switches to the distribution packages:
   
   - `ci/common.sh`: `brotli` + `libbrotli1` via apt
   - `docker/debian-dev/install-brotli.sh`: same
   - `docs/{en,zh}/latest/plugins/brotli.md`: recommend the distro packages 
instead of a source build
   
   `brotli-ffi` calls `ffi.load("brotlienc")`, which resolves the unversioned 
soname (`libbrotlienc.so`). Distributions ship those symlinks only in 
`libbrotli-dev` / `brotli-devel`, so the scripts and the docs create them 
against the packaged `.so.1`, which keeps them valid across package upgrades. 
Without this step the binding fails with `libbrotlienc.so: cannot open shared 
object file`.
   
   The docs now also tell users they can simply install the development package 
if they prefer.
   
   #### Which issue(s) this PR fixes:
   
   N/A
   
   ### Checklist
   
   - [x] I have explained the need for this PR and the problem it solves
   - [x] I have explained the changes or the new features added to this PR
   - [ ] I have added tests corresponding to this change
   - [x] I have updated the documentation to reflect this change
   - [x] I have verified that this change is backward compatible (If not, 
please discuss on the [APISIX mailing 
list](https://github.com/apache/apisix/tree/master#community) first)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to