kayx23 commented on code in PR #13651: URL: https://github.com/apache/apisix/pull/13651#discussion_r4582410785
########## docs/en/latest/plugins/openid-connect.md: ########## @@ -92,7 +92,11 @@ The `openid-connect` Plugin supports the integration with [OpenID Connect (OIDC) | session.absolute_timeout | integer | False | | | Absolute session lifetime in seconds. Forwarded to lua-resty-session as `absolute_timeout`. | | session.cookie.lifetime | integer | False | | | Deprecated. Mapped to `session.absolute_timeout` at runtime when `absolute_timeout` is not set. Use `session.absolute_timeout` instead. | | session.storage | string | False | cookie | ["cookie", "redis"] | Session storage method. | -| session.redis | object | False | | | Redis configuration when `storage` is `redis`. | +| session.revocation | string | False | | ["redis"] | Session revocation backend. Set to `redis` to enable revocation for cookie sessions. Requires `session.redis` and cannot be used when `session.storage` is `redis`. | +| session.revocation_fail_mode | string | False | open | ["open", "closed"] | When the revocation store is unreachable, `open` treats the session as not revoked, while `closed` rejects session open and destroy operations. | +| session.revocation_cache_ttl | integer | False | | | Worker-local TTL in seconds for successful revocation lookups. `0` disables. lua-resty-session defaults to `5`. | Review Comment: The Default column should be `5` for both `session.revocation_cache_ttl` and `session.revocation_error_cache_ttl`. This PR upgrades to lua-resty-session 4.3.0, whose runtime defaults are 5 seconds for both fields; the table already reports the library default for `revocation_fail_mode`, so leaving these cells blank makes the effective configuration inconsistent. Please update the corresponding Chinese rows as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
