juzhiyuan commented on a change in pull request #807:
URL: https://github.com/apache/apisix-dashboard/pull/807#discussion_r524823060
##########
File path: .gitignore
##########
@@ -42,6 +42,9 @@ build
manager-api
output
+publish
Review comment:
We use `publish` as a folder is not a good idea, can you provide some
examples of other popular projects using this name?
The act of ordering this line is to package the product, and we need to
think about whether we need to do this here.
If we need a package as the final product, then just packaged it in the
build process.
If we use a package just to let users move it easily, let's call it `make
package`, but I don't think it's needed and will take the confusion with `make
build`.
I would prefer packaging in the final build process or just removed this
command to reduce the confusion.
cc @moonming @membphis any ideas?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
