membphis commented on a change in pull request #2817:
URL: https://github.com/apache/apisix/pull/2817#discussion_r531262634
##########
File path: apisix/init.lua
##########
@@ -629,6 +630,24 @@ end
function _M.http_header_filter_phase()
core.response.set_header("Server", ver_header)
+ local function set_res_header(up_status)
+ core.response.set_header("X-APISIX-Upstream-Status", up_status)
Review comment:
bad function name, what means `res`?
##########
File path: apisix/init.lua
##########
@@ -629,6 +630,24 @@ end
function _M.http_header_filter_phase()
core.response.set_header("Server", ver_header)
+ local function set_res_header(up_status)
Review comment:
bad style, move this function out
##########
File path: doc/README.md
##########
@@ -35,6 +35,7 @@
* [Changelog](../CHANGELOG.md)
* [Benchmark](benchmark.md)
* [Code Style](../CODE_STYLE.md)
+* [Debug function](debugging.md)
Review comment:
I do not think `debugging.md` is a good name for this doc
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
