membphis commented on a change in pull request #927: URL: https://github.com/apache/apisix-dashboard/pull/927#discussion_r533114051
########## File path: api/test/e2e/route_with_management fileds_test.go ########## @@ -0,0 +1,282 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package e2e + +import ( + "io/ioutil" + "net/http" + "testing" + "time" + + "github.com/stretchr/testify/assert" + "github.com/tidwall/gjson" +) + +func TestRoute_with_name_desc(t *testing.T) { + tests := []HttpTestCase{ + { + caseDesc: "config route with name and desc (r1)", + Object: MangerApiExpect(t), + Path: "/apisix/admin/routes/r1", + Method: http.MethodPut, + Body: `{ + "uri": "/hello", + "name": "jack", + "desc": "config route with name and desc", + "upstream": { + "type": "roundrobin", + "nodes": [{ + "host": "172.16.238.20", + "port": 1980, + "weight": 1 + }] + } + }`, + Headers: map[string]string{"Authorization": token}, + ExpectStatus: http.StatusOK, + }, + { + caseDesc: "access the route's uri (r1)", + Object: APISIXExpect(t), + Method: http.MethodGet, + Path: "/hello", + Headers: map[string]string{"Authorization": token}, + ExpectStatus: http.StatusOK, + ExpectBody: "hello world", + Sleep: sleepTime, + }, + { + caseDesc: "verify the route's content (r1)", + Object: MangerApiExpect(t), + Path: "/apisix/admin/routes/r1", + Method: http.MethodGet, + Headers: map[string]string{"Authorization": token}, + ExpectStatus: http.StatusOK, + ExpectBody: "\"name\":\"jack\",\"desc\":\"config route with name and desc\"", + Sleep: sleepTime, + }, + } + for _, tc := range tests { + testCaseCheck(tc) + } + + tests = []HttpTestCase{ + { + caseDesc: "delete the route (r1)", + Object: MangerApiExpect(t), + Method: http.MethodDelete, + Path: "/apisix/admin/routes/r1", + Headers: map[string]string{"Authorization": token}, + ExpectStatus: http.StatusOK, + }, + } + + for _, tc := range tests { + testCaseCheck(tc) + } + + tests = []HttpTestCase{ + { + caseDesc: "config route with name, desc, create_time, update_time", + Object: MangerApiExpect(t), + Path: "/apisix/admin/routes/r1", + Method: http.MethodPut, + Body: `{ + "uri": "/hello", + "name": "jack", + "create_time": 1604046556, Review comment: `create_time` and `update_time` are fields maintained by manager-api, and we do not need the caller to care about them. so I think we can delete `create_time` and `update_time` here. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
