tokers commented on a change in pull request #958:
URL: https://github.com/apache/apisix-dashboard/pull/958#discussion_r535011824
##########
File path: api/internal/core/entity/entity.go
##########
@@ -220,3 +220,12 @@ type Script struct {
ID string `json:"id"`
Script interface{} `json:"script,omitempty"`
}
+
+type ServerInfo struct {
+ BaseInfo
+ LastReportTime int `json:"last_report_time,omitempty"`
+ UpTime int `json:"up_time,omitempty"`
Review comment:
Ditto.
##########
File path: api/internal/core/entity/entity.go
##########
@@ -220,3 +220,12 @@ type Script struct {
ID string `json:"id"`
Script interface{} `json:"script,omitempty"`
}
+
+type ServerInfo struct {
+ BaseInfo
+ LastReportTime int `json:"last_report_time,omitempty"`
Review comment:
By convention we use `int64` to store timestamp.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
