tokers commented on a change in pull request #66:
URL:
https://github.com/apache/apisix-ingress-controller/pull/66#discussion_r538918860
##########
File path: build.sh
##########
@@ -7,5 +7,5 @@ sed -i -e "s%#syslogAddress#%`echo $SYSLOG_HOST`%g"
${pwd}/conf.json
sed -i -e "s%#apisixBaseUrl#%`echo $APISIX_BASE_URL`%g" ${pwd}/conf.json
cd /root/ingress-controller
-exec ./ingress-controller
+exec ./ingress-controller ingress
Review comment:
We put all core logic about "ingress controller" in the sub command
ingress, and we can extend this tool by adding others sub command, for
instance, some debugging tools to fetch its internal states, or adding the
service apis support by the "gateway" sub command. So using sub commands is
more flexible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
