tokers commented on a change in pull request #82:
URL:
https://github.com/apache/apisix-ingress-controller/pull/82#discussion_r541819095
##########
File path: cmd/ingress/ingress.go
##########
@@ -39,6 +41,15 @@ func dief(template string, args ...interface{}) {
os.Exit(1)
}
+func waitForSignal(stopCh chan struct{}) {
+ sigCh := make(chan os.Signal, 1)
+ signal.Notify(sigCh, syscall.SIGINT, syscall.SIGTERM)
Review comment:
Behavior of SIGKILL cannot be changed, it's kernel's limitation.
I cannot understand why we should capture SIGABRT only because people may
send it, if so, wo have to capture all signals since people may send them as
well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
