imjoey commented on a change in pull request #1049:
URL: https://github.com/apache/apisix-dashboard/pull/1049#discussion_r545641794
##########
File path: api/internal/core/entity/entity.go
##########
@@ -83,6 +83,7 @@ type Route struct {
ServiceProtocol string
`json:"service_protocol,omitempty"`
Labels map[string]string `json:"labels,omitempty"`
EnableWebsocket bool
`json:"enable_websocket,omitempty"`
+ Status uint8 `json:"status"`
Review comment:
> sure, we can optimize this place. but they are not in the same bag and
cannot be used directly in this way.
@nic-chen thanks for getting back to me. Shall we also need to use `*uint8`
here instead of `uint8`? While honestly, the passed CI makes me rather
confused, am I missing anything that could explicitly tell us the `status`
param is **unset** or **set to 0**? This would bring great impact on creating a
Route. Any feedback is much appreciated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
