gy09535 commented on a change in pull request #3129:
URL: https://github.com/apache/apisix/pull/3129#discussion_r549944662
##########
File path: t/core/utils.t
##########
@@ -239,3 +236,32 @@ res:tell David to
res:John and David
res: and David
res:John and \$me
+
+
+
+=== TEST 7: resolve with search
+--- config
+ location /t {
+ content_by_lua_block {
+ local core = require("apisix.core")
+ local resolvers = {"223.5.5.5", "223.6.6.6"}
+ local search = {"google.com"}
+ local ndots = 5
+ core.utils.init_dns_proxy({
+ ndots = ndots,
+ search = search,
+ resolvers = resolvers,
+ })
+ local ip_info, err = core.utils.dns_parse("news.google.com")
Review comment:
> Try to resolve domain like `news`, since we have the custom `search`
option, `news.google.com` will be resolved.
>
> Also, it's not good to depend on external suite, it might cause the CI
unstable.
It should the dns serve support, such as core dns, we can not mock it. We
can change it to github.com to avoid the CI unstable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
