[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1326: fix(fe): update url regexp in online debug

[GitBox]

liuxiran commented on a change in pull request #1326:
URL: https://github.com/apache/apisix-dashboard/pull/1326#discussion_r561425643



##########
File path: web/cypress/integration/route/online-debug.spec.js
##########
@@ -54,6 +54,9 @@ context('Online debug', () => {
       
cy.get(domSelector.uriInput).type(`${defaultSettings.serveUrlMap[SERVE_ENV].split('//').pop()}${uri}`);
       cy.contains(routeLocaleUS['page.route.button.send']).click();
       // should not show the notification
+      
+      // test ci failed 
+      cy.wait(500)

Review comment:
       The regular expression does not take into account the case of 
`localhost`, that is why CI failed🤣, I will update soon, thanks all your help 
@LiteSun @juzhiyuan 

##########
File path: web/cypress/integration/route/online-debug.spec.js
##########
@@ -21,19 +21,20 @@ import defaultSettings from 
'../../../config/defaultSettings';
 
 context('Online debug', () => {
   const urisWithSpecialChars = [
-    '/get',
-    '/deps-get',
-    '/deps.get',
-    '/deps_get',
-    '/get?search=1',
-    '/get?search=%U%E',
-    '/get?search=v1&number=-1',
-    '/get?search=1+1',
+    'localhost:9000/get',
+    '127.0.0.1:9000/get',
+    'baidu.com/get',

Review comment:
       > `baidu` may not exist here, could we use a library to do this check?
   
   It will take a little time to research, let me have a try

##########
File path: web/cypress/integration/route/online-debug.spec.js
##########
@@ -21,19 +21,20 @@ import defaultSettings from 
'../../../config/defaultSettings';
 
 context('Online debug', () => {
   const urisWithSpecialChars = [
-    '/get',
-    '/deps-get',
-    '/deps.get',
-    '/deps_get',
-    '/get?search=1',
-    '/get?search=%U%E',
-    '/get?search=v1&number=-1',
-    '/get?search=1+1',
+    'localhost:9000/get',
+    '127.0.0.1:9000/get',
+    'baidu.com/get',

Review comment:
       for data: `baidu.com/get` just a case to test the host which does not 
contain `www`, and network does not affect the execution of test case, so I 
keep `baidu.com/get` in the data ^_^ @juzhiyuan 
   
   and for the regexp,  I just tried a simpler one to cover complex situations.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org