juzhiyuan commented on a change in pull request #1347:
URL: https://github.com/apache/apisix-dashboard/pull/1347#discussion_r562296901
##########
File path: web/src/pages/Service/Create.tsx
##########
@@ -81,13 +81,12 @@ const Page: React.FC = (props) => {
(serviceId ? update(serviceId, data) : create(data))
.then(() => {
notification.success({
- message: `${
- serviceId
+ message: `${serviceId
? formatMessage({ id: 'component.global.edit' })
: formatMessage({ id: 'component.global.create' })
- } ${formatMessage({ id: 'menu.service' })} ${formatMessage({
- id: 'component.status.success',
- })}`,
+ } ${formatMessage({ id: 'menu.service' })} ${formatMessage({
Review comment:
format
##########
File path: web/src/pages/Service/Create.tsx
##########
@@ -71,8 +71,8 @@ const Page: React.FC = (props) => {
};
const upstreamFormData = upstreamRef.current?.getData();
- if (upstreamFormData.upstream_id === '') {
- data.upstream = omit(upstreamFormData, ['upstream_id']);
+ if (!upstreamFormData.upstream_id) {
Review comment:
Is it possible to have something like:
```js
{
"upstream_id": "",
"xxx": ""
}
```
in `upstreamFormData`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
