tokers commented on a change in pull request #20: URL: https://github.com/apache/apisix-helm-chart/pull/20#discussion_r562338355
########## File path: README.md ########## @@ -44,14 +44,15 @@ helm uninstall apisix ./chart/apisix -n default 1. How to install APISIX only? -The Charts will install etcd 3.4.14 by default. If you want to install Apache APISIX only, please set `etcd.enabled=false` and set `etcd.host=http://your_etcd_address:2379`. +The Charts will install etcd 3.4.14 by default. If you want to install Apache APISIX only, please set `etcd.enabled=false` and set `etcd.host={http://your_etcd_address:2379}`. Review comment: Strange, if i don't want to install etcd, why should i still care and set the etcd host? ########## File path: README.md ########## @@ -44,14 +44,15 @@ helm uninstall apisix ./chart/apisix -n default 1. How to install APISIX only? -The Charts will install etcd 3.4.14 by default. If you want to install Apache APISIX only, please set `etcd.enabled=false` and set `etcd.host=http://your_etcd_address:2379`. +The Charts will install etcd 3.4.14 by default. If you want to install Apache APISIX only, please set `etcd.enabled=false` and set `etcd.host={http://your_etcd_address:2379}`. Please use the FQDN address or the IP of the etcd. ```shell +# if etcd export by kubernetes service need spell fully qualified name $ helm install apisix ./chart/apisix -n default \ --set etcd.enabled=false \ - --set etcd.host=http://your_etcd_address:2379 + --set etcd.host={http://etcd_node_1:2379\,http://etcd_node_2:2379} Review comment: Better to add some descriptions about how people can pass multiple etcd hosts. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
