membphis commented on a change in pull request #2101: URL: https://github.com/apache/apisix/pull/2101#discussion_r561775948
########## File path: .github/workflows/lint.yml ########## @@ -1,6 +1,6 @@ name: ❄️ Lint -on: [pull_request] +on: [push, pull_request] Review comment: why do we need to change it in this PR? one PR for one thing ########## File path: .travis/linux_openresty_common_runner.sh ########## @@ -108,7 +108,7 @@ script() { ./bin/apisix init_etcd ./bin/apisix start - #start again --> fial + #start again --> fail Review comment: we should fix it in a new PR. one PR for one thing ########## File path: Makefile ########## @@ -98,7 +98,7 @@ endif ### stop: Stop the apisix server .PHONY: stop stop: default - $(OR_EXEC) -p $$PWD/ -c $$PWD/conf/nginx.conf -s stop + ./bin/apisix stop Review comment: ditto ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org