[GitHub] [apisix] unbeatablekb commented on a change in pull request #3084: feat: add proxy_ssl_server_name

[GitBox]

unbeatablekb commented on a change in pull request #3084:
URL: https://github.com/apache/apisix/pull/3084#discussion_r564216971



##########
File path: t/APISIX.pm
##########
@@ -384,6 +384,24 @@ _EOC_
         }
     }
 
+    server {
+        listen 1985 ssl;

Review comment:
       Thanks. I used to create a new server block because I want to add 
`server_name` to new block. Now I think this make no sense after thinking about 
it.
   
   But you said I could write a new one in APISIX.pm. What does that means?
   
   
![image](https://user-images.githubusercontent.com/18637307/105802506-49c1a680-5fd6-11eb-9bfd-69565a3dbf54.png)
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org