Junnplus commented on a change in pull request #213: URL: https://github.com/apache/apisix-ingress-controller/pull/213#discussion_r564992048
########## File path: charts/apisix-ingress-controller/README.md ########## @@ -0,0 +1,44 @@ +<!-- +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +--> + +# Apache APISIX Ingress Controller Helm Chart + +## Prerequisites + +- Kubernetes 1.12+ +- [Apche APISIX](https://github.com/apache/apisix#configure-and-installation) +- [Helm v3.0+](https://helm.sh/docs/intro/quickstart/#install-helm) + +## Install + +Before installing the chart, you must first install [Apche APISIX](https://github.com/apache/apisix#configure-and-installation). + +To install the chart with release name `apisix-ingress-controller`: + +```bash +helm install apisix-ingress-controller --namespace apisix . Review comment: > Better to add a cd ./charts/apisix-ingress-controller if the directory in helm install is .. This readme document provides instructions for this chart, so I think use `.` is ok. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org