Junnplus commented on a change in pull request #26:
URL: https://github.com/apache/apisix-helm-chart/pull/26#discussion_r569105495



##########
File path: chart/apisix/values.yaml
##########
@@ -190,5 +191,7 @@ nodeSelector: {}
 
 tolerations: []
 
+# It sets the anti-affinity of the Pod by default, if the affinity.enabled is 
set to true. 
+# If you want to set other affinity configuration, please modify the affinity 
item in tmplate/deployment.yaml

Review comment:
       This is very unfriendly to users for modify `deployment.yaml`.
   
   `affinity.enabled` is not a good solution for anti-affinity. We should add 
like `antiAffinity.enabled` to instead of it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to