liuxiran commented on a change in pull request #1451:
URL: https://github.com/apache/apisix-dashboard/pull/1451#discussion_r571742709
##########
File path: web/cypress/integration/route/create-route-with-upstream.spec.js
##########
@@ -46,32 +47,27 @@ context('Create Route with Upstream', () => {
cy.contains('Submit').click();
});
- it('should enter the Route creator', function () {
+ it('should create route with upstream just created', function () {
Review comment:
While learning how to use `beforeAll`, I saw the best practices of
cypress[1],
> Anti-Pattern: Coupling multiple tests together.
Best Practice: Tests should always be able to be run independently from one
another and still pass.
> Anti-Pattern: Acting like you’re writing unit tests.
Best Practice: Add multiple assertions and don’t worry about it
As There is an interdependence between those small test cases, it would be
better to use more `assertions` in a merged test case.
Reference:
[1]
https://docs.cypress.io/guides/references/best-practices.html#Dangling-state-is-your-friend
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
