tokers commented on a change in pull request #252:
URL:
https://github.com/apache/apisix-ingress-controller/pull/252#discussion_r572629442
##########
File path: pkg/ingress/controller/controller.go
##########
@@ -254,7 +259,7 @@ func (c *Controller) run(ctx context.Context) {
}
c.goAttach(func() {
- c.epInformer.Run(ctx.Done())
+ c.endpointsController.getInformer().Run(ctx.Done())
Review comment:
I'm not sure whether I have the correct understanding of this
`endpointsController`, but seems it doesn't have big advantages here to
abstract it except we can write less `if` and `else` branches.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
