membphis commented on a change in pull request #3629:
URL: https://github.com/apache/apisix/pull/3629#discussion_r582423351
##########
File path: apisix/upstream.lua
##########
@@ -179,7 +179,12 @@ function _M.set_by_route(route, api_ctx)
if not dis then
return 500, "discovery " .. up_conf.discovery_type .. " is
uninitialized"
end
- local new_nodes = dis.nodes(up_conf.service_name)
+
+ local new_nodes, err = dis.nodes(up_conf.service_name)
+ if not new_nodes then
+ return http_code_upstream_unavailable, "no valid upstream node: "
.. (err or "nil")
Review comment:
`http_code_upstream_unavailable`:
For static variables, use capital letters
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
