membphis commented on a change in pull request #3698:
URL: https://github.com/apache/apisix/pull/3698#discussion_r584123788



##########
File path: docs/en/latest/plugins/skywalking.md
##########
@@ -133,7 +133,7 @@ plugin_attr:
         3. Run skywalking server:
 
             ```shell
-            sudo docker run --name skywalking -d -p 1234:1234 -p 11800:11800 
-p 12800:12800 --restart always --link elasticsearch:elasticsearch -e 
SW_STORAGE=elasticsearch -e SW_STORAGE_ES_CLUSTER_NODES=elasticsearch:9200 
apache/skywalking-oap-server
+            sudo docker run --name skywalking -d -p 1234:1234 -p 11800:11800 
-p 12800:12800 --restart always --link elasticsearch:elasticsearch -e 
SW_STORAGE=elasticsearch -e SW_STORAGE_ES_CLUSTER_NODES=elasticsearch:9200 
apache/skywalking-oap-server:8.3.0-es7

Review comment:
       I think there should be `8.3.0-es7`.
   
   I got it from 
https://github.com/apache/skywalking-docker/blob/master/oap-server/README.md
   
   Or we can remove the doc about `Of Course, you can use Elasticsearch 
storage`, just link to the doc of SkyWalking.
   
   what do you think @moonming ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to