spacewander commented on a change in pull request #3621:
URL: https://github.com/apache/apisix/pull/3621#discussion_r584451362
##########
File path: utils/centos7-ci.sh
##########
@@ -57,11 +57,11 @@ install_dependencies() {
# install dependencies
git clone https://github.com/iresty/test-nginx.git test-nginx
make deps
- make init
Review comment:
Why move this line?
##########
File path: utils/centos7-ci.sh
##########
@@ -27,7 +27,7 @@ install_dependencies() {
# install openresty
yum install -y yum-utils && yum-config-manager --add-repo
https://openresty.org/package/centos/openresty.repo
- yum install -y openresty-debug openresty-openssl111-debug-devel
+ yum install -y openresty openresty-debug openresty-openssl111-debug-devel
Review comment:
Why install `openresty`?
##########
File path: .github/workflows/centos7-ci.yml
##########
@@ -29,6 +27,15 @@ jobs:
with:
submodules: recursive
+ - name: Build rpm package
+ if: ${{ startsWith(github.ref, 'refs/heads/release/') &&
!endsWith(matrix.os_name, 'luarocks') }}
Review comment:
The `os_name` can't be `luarocks`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
