[GitHub] [apisix] jp-gouin commented on a change in pull request #3691: feat: Add filter on HTTP methods for consumer-restriction plugin

[GitBox]

jp-gouin commented on a change in pull request #3691:
URL: https://github.com/apache/apisix/pull/3691#discussion_r585652896



##########
File path: apisix/plugins/consumer-restriction.lua
##########
@@ -114,12 +161,16 @@ function _M.access(conf, ctx)
         if not is_include(value, conf.whitelist) then
             block = true
         end
+        if conf.allowed_methods and #conf.allowed_methods > 0 then
+            if not is_method_allow(conf.allowed_methods, method, value) then

Review comment:
       agree 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org