bisakhmondal commented on pull request #1564: URL: https://github.com/apache/apisix-dashboard/pull/1564#issuecomment-792887934
>The drawer in route and service also needs to be handled. You can search globally for this component to prevent missing some pages Hey @LiteSun, for the plugins @ route and service, components are reflecting the current changes. It's using the existing `PluginPage` component (on which the changes have been made) for rendering the plugins in different use cases. for example inside `service` https://github.com/apache/apisix-dashboard/blob/6dce9e09640b1c81f14dbb88e5f6f8c43371af31/web/src/pages/Service/Create.tsx#L133-L135 in `routes` https://github.com/apache/apisix-dashboard/blob/6dce9e09640b1c81f14dbb88e5f6f8c43371af31/web/src/pages/Route/components/Step3/index.tsx#L86-L95 In short, if I am not mistaken, desired changes are getting reflected for plugins across the components you mentioned. Do you want me to add an extra optional prop (`maskClosable`) for `PluginPage` itself to get a more precise control over the mask to use it from any page? Thanks for the approval @juzhiyuan 😄 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
