spacewander commented on issue #3827:
URL: https://github.com/apache/apisix/issues/3827#issuecomment-799899506


   > 
   > 
   > > > > if we put the zipkin plugin to the last, requests rejected by 
previous plugins won't be traced.
   > > > 
   > > > 
   > > > Does this problem exist no matter whether we put this plugin on the 
first or the last?
   > > 
   > > 
   > > Why does this problem exist if we run the plugin first?
   > 
   > If we run the plugin first, we record the duration of the last phase at 
the beginning of the current phase. if the request was rejected in last phase, 
we can not record the duration.
   
   I see. I thought "this problem" is "rejected by previous plugins won't be 
traced" so I mislead your reply.
   
   Actually, we can't measure the time of phases correctly. Therefore I advise 
reassigning the span into proxy/response which is doubtless.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to