spacewander commented on a change in pull request #3848:
URL: https://github.com/apache/apisix/pull/3848#discussion_r597337548
##########
File path: apisix/discovery/consul_kv.lua
##########
@@ -230,6 +241,73 @@ local function update_application(server_name_prefix, data)
end
+local function read_dump_srvs()
+ local data, err = util.read_file(dump_params.path)
+ if not data then
+ log.warn("read dump file get error: ", err)
Review comment:
So you suggest to prepare the dump file before staring APISIX to avoid
the unexpected event (file not found)?
##########
File path: apisix/discovery/consul_kv.lua
##########
@@ -230,6 +241,73 @@ local function update_application(server_name_prefix, data)
end
+local function read_dump_srvs()
+ local data, err = util.read_file(dump_params.path)
+ if not data then
+ log.warn("read dump file get error: ", err)
Review comment:
@yongboy
So you suggest to prepare the dump file before staring APISIX to avoid the
unexpected event (file not found)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
