[GitHub] [apisix-dashboard] stu01509 commented on a change in pull request #1633: feat: add the service page upstream select option

[GitBox]

stu01509 commented on a change in pull request #1633:
URL: https://github.com/apache/apisix-dashboard/pull/1633#discussion_r598116103



##########
File path: web/src/components/Upstream/UpstreamForm.tsx
##########
@@ -663,6 +663,9 @@ const UpstreamForm: React.FC<Props> = forwardRef(
                   name: formatMessage({ id: 
'page.upstream.step.select.upstream.select.option' }),
                   id: '',
                 },
+                {
+                  name: formatMessage({ id: 
'page.upstream.step.select.upstream.select.none' }),

Review comment:
       Hi @bisakhmondal 
   
   Thanks for your mention, I think it may need to wait for @juzhiyuan and 
@Firstsawyou confirm haha.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org