tokers commented on a change in pull request #3871:
URL: https://github.com/apache/apisix/pull/3871#discussion_r598371405



##########
File path: docs/en/latest/admin-api.md
##########
@@ -657,12 +659,44 @@ After the execution is successful, nodes will not retain 
the original data, and
 
 ```
 
+Example 2: How to proxy upstream https.

Review comment:
       Bad title, I think "How to proxy requests to upstream with HTTPS scheme" 
is better.

##########
File path: docs/zh/latest/admin-api.md
##########
@@ -665,11 +668,42 @@ HTTP/1.1 200 OK
 
 ```
 
+示例二:如何代理上游 https。
+
+1、创建 route 并 配置 upstream 的 scheme 为 `https`。
+
+```shell
+$ curl -i http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: 
edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
+{
+    "uri": "/get",
+    "upstream": {
+        "type": "roundrobin",
+        "scheme": "https",
+        "nodes": {
+            "httpbin.org:443": 1
+        }
+    }
+}'
+```
+
+执行成功后,请求与上游通信时的 scheme 将为 `https`。
+
+2、 发送请求进行测试。
+
+```shell
+$ curl http://127.0.0.1:9080/get -i

Review comment:
       IMHO, this test case lacks persuasion. You'd better also print the 
result returned by the upstream.

##########
File path: docs/zh/latest/admin-api.md
##########
@@ -665,11 +668,42 @@ HTTP/1.1 200 OK
 
 ```
 
+示例二:如何代理上游 https。
+
+1、创建 route 并 配置 upstream 的 scheme 为 `https`。

Review comment:
       The empty space between `并` and `配置` is redundant.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to