juzhiyuan commented on a change in pull request #1641:
URL: https://github.com/apache/apisix-dashboard/pull/1641#discussion_r598673783
##########
File path: web/src/pages/Metrics/locales/en-US.ts
##########
@@ -17,5 +17,5 @@
export default {
'page.metrics.empty.description.grafanaNotConfig': 'You have not configured
Grafana',
'page.metrics.button.grafanaConfig': 'Configure',
- 'page.metrics.tip': 'Use browser iframe to store monitor page URL, local
only.',
+ 'page.metrics.tip': 'Use browser localStorage to store monitor page URL,
local only.',
};
Review comment:
would better to use `metrics` all the paces
##########
File path: web/src/pages/Metrics/locales/en-US.ts
##########
@@ -17,5 +17,5 @@
export default {
'page.metrics.empty.description.grafanaNotConfig': 'You have not configured
Grafana',
'page.metrics.button.grafanaConfig': 'Configure',
- 'page.metrics.tip': 'Use browser iframe to store monitor page URL, local
only.',
+ 'page.metrics.tip': 'Use browser localStorage to store monitor page URL,
local only.',
};
Review comment:
would better to use `metrics` all the places
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
